Skip to content

ci: declare workflow-level contents: read on the 11 remaining workflows#123

Open
arpitjain099 wants to merge 1 commit into
ruby:masterfrom
arpitjain099:chore/declare-workflow-perms-readonly
Open

ci: declare workflow-level contents: read on the 11 remaining workflows#123
arpitjain099 wants to merge 1 commit into
ruby:masterfrom
arpitjain099:chore/declare-workflow-perms-readonly

Conversation

@arpitjain099
Copy link
Copy Markdown

Pins the default GITHUB_TOKEN to contents: read on the 11 workflows in .github/workflows/ that don't actually need any write scope:

  • bundled_gems.yml, coverage.yml, doxygen.yml, test_ruby_versions.yml, update_ci_versions.yml: test, lint, and coverage workflows. No GitHub API call beyond the initial checkout.
  • snapshot-master.yml, snapshot-ruby_3_3.yml, snapshot-ruby_3_4.yml, snapshot-ruby_4_0.yml: build the Ruby snapshot tarballs and upload them as workflow artifacts. No GitHub API mutation.
  • remove-tmp-package.yml: removes files from s3://ftp.r-l.o/pub/tmp/ and purges the Fastly cache. AWS credentials only, no GITHUB_TOKEN use.
  • update_index.yml: updates the index via AWS S3 credentials; no GITHUB_TOKEN use.

draft-release.yml is left implicit on purpose; it needs write scopes that are best declared by a maintainer who knows the release flow.

Why

CVE-2025-30066 (March 2025 tj-actions/changed-files supply-chain compromise) exfiltrated GITHUB_TOKEN from workflow logs and the leaked token retained whatever scope was issued at the workflow level. Pinning per workflow caps that runtime authority irrespective of the repo or org default, gives drift protection if the default ever widens, and is credited per-file by the OpenSSF Scorecard Token-Permissions check.

YAML validated locally with yaml.safe_load on each touched file.

Pins the default GITHUB_TOKEN to contents: read on the 11 workflows in
.github/workflows/ that don't actually need any write scope:

- bundled_gems.yml, coverage.yml, doxygen.yml, test_ruby_versions.yml,
  update_ci_versions.yml: test/build/lint workflows, no GitHub API.
- snapshot-master.yml, snapshot-ruby_3_3.yml, snapshot-ruby_3_4.yml,
  snapshot-ruby_4_0.yml: build snapshot tarballs and upload as
  workflow artifacts; no GitHub API mutation.
- remove-tmp-package.yml: removes files from S3 and purges the Fastly
  cache; AWS creds only, no GITHUB_TOKEN use.
- update_index.yml: updates the index via AWS S3 creds; no GITHUB_TOKEN
  use.

draft-release.yml is intentionally left implicit; it needs write
scopes that are best declared by a maintainer.

Motivation: CVE-2025-30066 (March 2025 tj-actions/changed-files
compromise) exfiltrated GITHUB_TOKEN from workflow logs. Per-workflow
caps bound runtime authority irrespective of repo or org default,
give drift protection if the default ever widens, and are credited
per-file by the OpenSSF Scorecard Token-Permissions check.

YAML validated locally with yaml.safe_load.

Signed-off-by: Arpit Jain <arpitjain099@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant