Skip to content

Show-source should not raise error even if line_no is wrong #1145

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
tompng merged 1 commit into from
Dec 4, 2025
Merged

Show-source should not raise error even if line_no is wrong #1145

tompng merged 1 commit into from
Dec 4, 2025
+24 −4

Conversation

@tompng
Copy link
Member

@tompng tompng commented Dec 3, 2025

Fix SourceFinder to handle wrong line_no case, such as:

  • line_no passed to eval is wrong
  • File edited after load

An example I actually experienced was:

  1. Run irb with irb -rlibname -Ilib
  2. Switch to another branch
  3. Run show_source

@tompng
Show-source should not raise error even if line_no is wrong
f844902 
Fix SourceFinder to handle wrong line_no case, such as:
- line_no passed to eval is wrong
- File edited after load
@st0012 st0012 added the bug Something isn't working label Dec 4, 2025
@tompng tompng merged commit 6d7ff96 into ruby:master Dec 4, 2025
33 checks passed
@tompng tompng deleted the source_location_less_line branch December 4, 2025 12:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@st0012 st0012 st0012 approved these changes

Assignees

No one assigned

Labels

bug Something isn't working

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@tompng @st0012