Keep large ordered sequence indices as integers - #743
Open
OskarEichler wants to merge 1 commit into
Open
Conversation
nevans
requested changes
Aug 29, 2026
Collaborator
There was a problem hiding this comment.
Please add a test.
Keep it fast by using a small number of large ranges. Too many elements will make it too slow. The example in the description is perfect.
That said, an index larger than UINT32_MAX is of very low practical value. It's far more likely to be abused than used intentionally. We may want to impose some limit on the maximum. But don't worry about that for this PR.
Although there's no risk of going over UINT32_MAX, #find_index also shouldn't use #export_num.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Return an integer position from find_ordered_index without applying sequence-number star conversion. Ordered entries may repeat, so their indices can reach 2**32 even though individual sequence numbers cannot. That integer currently becomes :*, breaking the index contract.
Reproduction
Verification
rake teston this isolated branch: 1726 tests, 12592 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications, Ruby 4.0.6 via rbenv. The baseline also passes all 1,726 tests; assertion counts vary slightly across runs.git diff --checkpass. No repository tests, dependencies or workflows were added or modified; focused reproductions live outside the repository under the consumer's no-new-tests policy.6d2ef7a636a1e2449187a83b06ac7a5baa54ead2; the runtime diff from released 0.6.6 is documentation-only before this patch.Compatibility and limits
No signature change. The affected boundary now returns its documented Integer index instead of a star Symbol. Actual sequence-number star conversion remains unchanged. Other Ruby/OS versions were not run locally. No production or external IMAP service was used. Local verification does not imply upstream CI approval or comprehensive behavioral coverage.