Reject END { break } for Ruby 3.5
#3707
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Earlopain
force-pushed
the
end-block-exit
branch
2 times, most recently
from
089fcda to
6eb14b3
Compare
For [Bug #20409]
Earlopain
force-pushed
the
end-block-exit
branch
from
6eb14b3 to
fda3bd0
Compare
kddnewton
approved these changes
Nov 23, 2025
| case PM_CONTEXT_SCLASS_ENSURE: | ||
| case PM_CONTEXT_SCLASS_RESCUE: | ||
| // https://bugs.ruby-lang.org/issues/20409 | ||
| if (context_node->context == PM_CONTEXT_POSTEXE) { |
Collaborator
There was a problem hiding this comment.
Slight preference here for this to be a fallthrough instead of checking again the type here, as in:
case PM_CONTEXT_POSTEXE:
if (...) { return; }
if (...) { return; }
PRISM_FALLTHROUGH
case ...:
assert(...);
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For [Bug #20409]