Conversation
Documentation previewCommit: |
Contributor
There was a problem hiding this comment.
🔵 Needs a closer look
The responsive dialog and keyboard-focus behavior warrant final browser verification.
Pull request overview
Adds discoverable keyboard shortcut help to Aliki’s search interface.
Changes:
- Adds a modal shortcut reference with desktop and mobile triggers.
- Implements keyboard, focus-restoration, and dismissal behavior.
- Adds responsive styling, an icon, and design documentation.
File summaries
| File | Description |
|---|---|
aliki/js/aliki.js |
Implements shortcut-dialog interactions. |
aliki/DESIGN.md |
Documents the shortcut-help design. |
aliki/css/rdoc.css |
Styles responsive hints and dialog. |
aliki/_search_shortcuts.rhtml |
Defines shortcut-help content. |
aliki/_icons.rhtml |
Adds the keyboard icon. |
aliki/_header.rhtml |
Integrates hints, triggers, and dialog. |
Review details
- Files reviewed: 6/6 changed files
- Comments generated: 0
- Review effort level: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I want to introduce more shortcuts to Aliki but there needs to be a way to surface them. So this PR adds a shortcut hint panel (named search shortcuts for now as that's the only feature that has them).
Please use the preview link in the 1st comment to play with it directly.