Make rclass_ext->const_tbl a managed object
#13807
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
casperisfine
force-pushed
the
rclass-marked-const-table
branch
2 times, most recently
from
b3689b6 to
202bebc
Compare
This comment has been minimized.
This comment has been minimized.
casperisfine
force-pushed
the
rclass-marked-const-table
branch
4 times, most recently
from
e420f5a to
23493ce
Compare
Contributor
Contributor
Author
|
Hum, that's a good catch. Thank you. |
casperisfine
force-pushed
the
rclass-marked-const-table
branch
from
e90e3df to
eaf45a1
Compare
Contributor
Author
|
Ref: ruby/debug#1151 |
Similar to `managed_id_table`, but the values are marked. This can be used to implement RCU pattern on id tables that contain marked objects (e.g. `class->const_tbl`).
casperisfine
force-pushed
the
rclass-marked-const-table
branch
from
eaf45a1 to
94e1d88
Compare
The table itself is a `rb_id_marked_table` and the values are `IMEMO/constentry`. This open the door to do RCU updates of constant tables.
casperisfine
force-pushed
the
rclass-marked-const-table
branch
from
94e1d88 to
5f6cdc9
Compare
casperisfine
force-pushed
the
rclass-marked-const-table
branch
from
5f6cdc9 to
22019c9
Compare
Contributor
Author
It did indeed fix one issue. Unfortunately the This also is unrelated to the write barrier issue :/. It's progress though. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The table itself is a
rb_id_marked_tableand the values areIMEMO/constentry.This open the door to do RCU updates of constant tables.