Improve font family with add lang attr #3718
Merged
+361
−237
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…HTML `lang` attribute transformation for improved accessibility and localization.
… and updated default font stacks for consistency.
…ibutes for native names and language codes.
…language-specific fonts for improved localization support.
…r better compatibility and consistency.
…ity and consistency in language-specific font rules.
…lt font settings.
…sign consistency.
sorah
reviewed
Dec 22, 2025
Member
sorah
left a comment
sorah
left a comment
There was a problem hiding this comment.
hi, I agree that lang attribute is important for rendering CJK text correctly especially on user agents set non-CJKs. 1 minor comment.
…improved readability and maintainability
…improved compatibility
…t` selectors for improved maintainability and readability
sorah
approved these changes
Dec 23, 2025
Member
|
thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added appropriate
langattributes based on language, adjusted thefont-familyaccordingly, and removed system-ui from thefont-familyto eliminate a factor that reduces readability in CJK environments.note: https://developer.mozilla.org/en-US/docs/Web/CSS/Reference/Properties/font-family#system-ui