ADR-0030: Place Expressions for Memory Locations #840
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implement Place abstraction in Rue's IR to represent memory locations (lvalues) as first-class values. This eliminates redundant Load instructions for array indexing and field access. Key changes: - Add Place, PlaceBase, Projection types to rue-cfg - Add PlaceRead/PlaceWrite instructions replacing FieldGet/IndexGet - Update x86_64 and aarch64 backends with place lowering methods - Update AIR with AirPlace, AirPlaceRef, and place-based instructions - Remove obsolete trace_field_chain/trace_index_chain methods This unified instruction set (2 instructions instead of 6) provides: - Smaller IR with fewer intermediate Load instructions - Simpler codegen that walks projections directly - Better optimization opportunities for aliasing analysis Resolves merge conflict with CfgLowerContext refactoring from trunk. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
steveklabnik
force-pushed
the
steveklabnik/push-lzpqmzmqpuqt
branch
from
7014134 to
685dd9b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement Place abstraction in Rue's IR to represent memory locations (lvalues) as first-class values. This eliminates redundant Load instructions for array indexing and field access.
Key changes:
This unified instruction set (2 instructions instead of 6) provides:
Resolves merge conflict with CfgLowerContext refactoring from trunk.
🤖 Generated with Claude Code