text: Allow specifying multiple device fonts for text fields #19274
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kjarosh
added
text
kjarosh
force-pushed
the
text-font-list
branch
from
3bb449a to
ec5b2f7
Compare
kjarosh
force-pushed
the
text-font-list
branch
2 times, most recently
from
f8daf5e to
1645906
Compare
kjarosh
force-pushed
the
text-font-list
branch
from
1645906 to
c4c3aec
Compare
adrian17
approved these changes
Mar 9, 2025
| .first() | ||
| { | ||
| // Specifying multiple font names is supported only for device fonts. | ||
| let font_names: Vec<&str> = font_name.split(",").collect(); |
There was a problem hiding this comment.
Would this work if you iterated on the split without collecting into a Vec?
There was a problem hiding this comment.
I could do that, sure, but then I'm using the vec to get the fallback font name and IMO it's clearer when I do font_names.first() compared to not collecting into a vec and doing something else.
That matches the behavior of Flash Player and Ruffle Desktop.
When device fonts are used, you can specify a list of font names for a text field, in which case the first one available will be used. No glyph fallback mechanism between fonts on the list is applied. This is true for both CSS and pure TextFormats.
This test verifies the behavior of styling with a list of fonts.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When device fonts are used, you can specify a list of font names for a text field, in which case the first one available will be used. No glyph fallback mechanism between fonts on the list is applied.
This is true for both CSS and pure
TextFormats.Additionally some refactors are included.