desktop: Implement basic IME support #19666
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kjarosh
added
text
On top of player events, which allow sending information from the frontend to the player, player notifications are a way of communicating back from the player to the frontend.
The basic IME support includes displaying popups in roughly the right position, and handling IME commit events without preediting yet.
Implements IME support (currently still limited by the core impl).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The basic IME support includes displaying popups in roughly the right position, and handling IME commit events without preediting yet.
Tested manually with Anthy (no automated tests yet due to lack of preediting).
IME preference is also added to the GUI (disabled by default):
