Remove some unnecessary RefCells in AVM1 objects
#19734
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
moulins
added
A-avm1
moulins
force-pushed
the
avm1-cells-optimize
branch
from
862c098 to
8886bbb
Compare
kjarosh
approved these changes
Mar 7, 2025
We don't need full mutable borrows here, and this avoids some runtime checks.
This avoids extra `RefCell`s and back-and-forth conversions to `String`.
moulins
force-pushed
the
avm1-cells-optimize
branch
from
8886bbb to
c4b05ee
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.