Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

avm2: Fix getChildByName to be case sensitive (close #19765) #19766

Merged
merged 1 commit into from
Mar 10, 2025

Conversation

MrCheeze
Copy link
Contributor

@MrCheeze MrCheeze commented Mar 10, 2025

As far as I can tell, there's no situation where this is ever case-insensitive, and it fixes the referenced issue.

Fixes #19765

@MrCheeze MrCheeze force-pushed the getchildbyname_case_sensitive branch from dfd6434 to 9545edb Compare March 10, 2025 01:14
@kjarosh kjarosh added A-avm2 Area: AVM2 (ActionScript 3) T-fix Type: Bug fix (in something that's supposed to work already) labels Mar 10, 2025
Copy link
Member

@kjarosh kjarosh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@kjarosh kjarosh force-pushed the getchildbyname_case_sensitive branch from 9545edb to a4b4de7 Compare March 10, 2025 09:44
@kjarosh kjarosh enabled auto-merge (rebase) March 10, 2025 09:45
@kjarosh kjarosh merged commit 0017048 into ruffle-rs:master Mar 10, 2025
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-avm2 Area: AVM2 (ActionScript 3) T-fix Type: Bug fix (in something that's supposed to work already)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Homestuck 2: [S] 8r8k - missing image
2 participants