-
Couldn't load subscription status.
- Fork 6.5k
Add Async class for Azure PostgreSQL integration #19995
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Add Async class for Azure PostgreSQL integration #19995
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why does this have to be a completely different class? Why not just implement the async methods in the existing class? (No other class takes this approach in the repo, feels kind of weird)
|
The initial idea was to keep the common code in a different package so that all of the Azure PostgreSQL integrations can share them. At some point we will refactor them once they are available to be imported. We use psycopg_pool which has separate pools for sync and async connections. We can try to accept both as an argument but that would make the code itself very ugly with requirements to if check all over the place. I don't think using both sync and async operations within a single class is that common of a use case. Please let me know if that is a hard requirement. |
|
Not a hard requirement, but it is pretty awkward and not aligned with any other integration. Likely a friction point Other integrations handle sync/async but just having a Users can't always control if a sync or async endpoint is being used |
|
Nah, reading that again, it is a requirement, and I don't think its that bad of an ask or will be that bad to implement |

Description
Add Async class for Azure PostgreSQL integration
Type of Change
Please delete options that are not relevant.
How Has This Been Tested?
Your pull-request will likely not be merged unless it is covered by some form of impactful unit testing.
Suggested Checklist:
uv run make format; uv run make lintto appease the lint gods