feat: google genai integration with tool block #20096
Merged
+131
−64
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
the
size:L
...-index-integrations/llms/llama-index-llms-google-genai/llama_index/llms/google_genai/base.py
Show resolved
Hide resolved
| "id": part.function_call.id if part.function_call.id else "", | ||
| "name": part.function_call.name, | ||
| "args": part.function_call.args, | ||
| "thought_signature": part.thought_signature, |
Collaborator
There was a problem hiding this comment.
I think we might be losing thought signatures here? Although not totally sure either
Member
Author
There was a problem hiding this comment.
Yeah, we might be, but ToolCallBlock does not have something that could properly handle the signature and I did not want to open it to additional_kwargs chaos... Although I can do that if we think it is necessary
...index-integrations/llms/llama-index-llms-google-genai/llama_index/llms/google_genai/utils.py
Outdated
Show resolved
Hide resolved
Collaborator
|
I'm still seeing some weird behaviour
|
logan-markewich
approved these changes
Nov 3, 2025
Collaborator
logan-markewich
left a comment
logan-markewich
left a comment
There was a problem hiding this comment.
This looks good to me now, thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding
ToolCallBlocksupport in GoogleGenAI integration (e2e tested)