feat: Add support for Ollama#39
Closed
Hari-Jeon wants to merge 4 commits into
Closed
Conversation
AstraBert
reviewed
Aug 14, 2025
Member
AstraBert
left a comment
There was a problem hiding this comment.
I'm not 100% sure this is a valuable addition: if we want to go local, we should be going all-in and replace all the remote services, otherwise I feel like this just complicates things
Member
|
Also all the CI checks are failing, we would need to make them pass before considering merging this change |
Author
|
Thanks for the feedback. I'll work on it some more. Until then, I'll close the pr and open it again later with an upgraded version. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds support for Ollama integration, allowing users to connect NotebookLlama with Ollama's model-serving framework while maintaining full backward compatibility.
Changes
OLLAMA_BASE_URLenv variableOPENAI_API_MODELandOLLAMA_MODELenv variablesREADME.mdand.env.exampleto include Ollama setup instructionsConfiguration
OLLAMA_BASE_URLin your.envfile to use Ollama models.OPENAI_API_MODELorOLLAMA_MODELin your.envfile to change the default LLMBackward Compatibility
This addresses the Ollama integration feature discussed in #10