fix: UI Jobs streams are not cleaned up after PR is closed

[joe1981al]

what

• Update func (p *PullClosedExecutor) CleanUpPull to use the updated definition of `PullInfo

why

• see related issue
• this commit updated the definition of PullInfo
• PullInfo wasn't updated in function used to cleanup job info, so matches were not found in the mapping

tests

• tested in my local environment with PRs from Azure Devops

references

• see issue

[chenrui333]

can you also add unit tests for such changes?

[joe1981al]

@chenrui333, I'm not deeply familiar with go unit testing, but it looks like there are test around this, but problem was not enough information was being passed to match what was actually in the map, so it thought everything related was being cleaned up but it was not matching the actual entry.

[joe1981al]

More details, on debugging done on p.LogStreamResourceCleaner.CleanUp(jobContext) that this calls.

I added more logging to see what the contents of the map p.pullToJobMapping, and this is what I had (removing identifying info):

{
 "{54106 repo azureorg/project/repo  terraform/project/path default}": {
  "0cea6de8-5618-405f-b819-42d377b6f5ae": {
   "JobID": "0cea6de8-5618-405f-b819-42d377b6f5ae",
   "JobIDUrl": "",
   "JobDescription": "",
   "Time": "2025-02-21T12:44:55.947183432-06:00",
   "TimeFormatted": "",
   "JobStep": "plan"
  }
 }
}

but looking at the input to the function:

jobs.PullInfo {PullNum: 54106, Repo: "repo", RepoFullName: "", ProjectName: "", Path: "", Workspace: "default"}

Some of the objects in the key were not included in the input, so the if statement for the matching was just skipping the removal since no maps matched and there are no checks to make sure items related to a pull are removed from the mapping.