Remove vmtest dependencies #183
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
April 2, 2018 12:09
…llState Expected output of interactive tests is also updated to reflect configuration changes.
Member
Author
|
I'm currently investigating why the more specific exclusion supplied by @pirapira does not work. |
added 6 commits
April 10, 2018 16:38
…ble failing VMTests
ehildenb
force-pushed
the
remove-vmtest-dependencies
branch
from
dd25fe2 to
b06e176
Compare
Member
Author
|
Turns out it doesn't have issues with the more specific exclusion, should work like this. |
…cking output of interactive tests
ehildenb
force-pushed
the
remove-vmtest-dependencies
branch
from
b06e176 to
fcc1198
Compare
Member
Author
|
Jenkins: test this please |
Member
Author
|
Jenkins: test this please |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes the dependencies on VMTEST mode from the file
evm.md(except for in the top-level execution loop).Note that we've manually disabled problematic VMTests for now, but ethereum/tests#444 should remove all problematic tests for us eventually.