Skip to content

Update README in Lesson 1.3 #4805

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

ibastys
Copy link
Contributor

@ibastys ibastys commented May 4, 2025

No description provided.

@ibastys
Copy link
Contributor Author

ibastys commented May 4, 2025

Line 188: Why are there so many AST representations?

Lines 188-189: Should we mention kore if we cannot give the reader any reference for it? Maybe another flag value is more relevant?

Lines 209-211: I could not find any other reference to inj attribute in the tutorial. Do you know where this is mentioned?

Lines 213-214: I added this sentence, but i am not 100% certain it is true.

Lines 451-452: Compiling with flag --gen-bison-parser or --gen-glr-bison-parser gives an additional warning. Could you say something about it?

Lines 478-502: I didn't get an error when parsing after compilation with bison flags on. When compiling with flag --gen-glr... i get two ASTs, correct?

are not supported by Bison.
```

We now have a second warning.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Compiling with flag --gen-bison-parser or --gen-glr-bison-parser gives an additional warning. Could you say something about it?

)
```

In this case, we get both ASTs.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't get an error when parsing after compilation with bison flags on. When compiling with flag --gen-glr... i get two ASTs, correct?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant