-
Notifications
You must be signed in to change notification settings - Fork 12
Prebuild optimized definition #1002
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
automergerpr-permission-manager
merged 12 commits into
master
from
prebuilt-optimizations
Mar 26, 2025
Merged
Prebuild optimized definition #1002
automergerpr-permission-manager
merged 12 commits into
master
from
prebuilt-optimizations
Mar 26, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9 tasks
…se build - Makes new file kontrol.md with module KONTROL-BASE, and adjusts build targets to use this. - Automatically includes the NO-STACK-CHECKS module and NO-CODE-SIZE-CHECKS module directly into main definition.
…tions for options regarding the extra lemmas to include
…Y-MAIN => KONTROL-MAIN
7d215b8
to
6d1eac7
Compare
palinatolmach
approved these changes
Mar 26, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
Co-authored-by: Palina <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of: #977
This PR changes the way we handle options
--no-keccak-lemmas
and--auxiliary-lemmas
so that we do not require building them in atkontrol build ...
time. Instead, we prebuild base Kontrol definitions with and without these lemmas in context directly. In particular:kontrol.md
is added with new build modules, and the corresponding definitions:KONTROL-BASE
(no additional lemmas),KONTROL-AUX
(with auxiliary lemmas),KONTROL-KECCAK
(with the keccak lemmas), andKONTROL-FULL
(with both sets of additional lemmas).kdist
targets for each build module are added.kontrol build ...
process is modified to use the corresponding base defnitiion according to what the user supplies on the CLI instead of building them in dynamically.<schedule>
is removed from a rule inno_stack_size_checks.md
where it is useless.KONTROL-MAIN
instead ofFOUNDRY-MAIN
, which means that when extra lemmas are supplied via CLI tokontrol prove ...
, that lemmas file needs to be adjusted to importKONTROL-MAIN
instead ofFOUNDRY-MAIN
.