Update/generalize option to include lemmas at prove time #979
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
automergerpr-permission-manager bot
pushed a commit
to runtimeverification/k
that referenced
this pull request
Mar 14, 2025
This PR factors out the ability to add KAST level modules to the RPC server via `CTermSymbolic`, so that the user doesn't need to manually do the conversions needed for adding such modules. The `APRProver` is refactored to use this new `CTermSymbolic.add_module` as well. This is part of runtimeverification/kontrol#977, and blocking runtimeverification/kontrol#979.
ehildenb
force-pushed
the
remove-build-lemmas
branch
from
80471c3 to
b6490c4
Compare
…to RpcOptions, deprecate --extra-module
…ded at prove time
ehildenb
force-pushed
the
remove-build-lemmas
branch
from
b6490c4 to
d23ee0d
Compare
ehildenb
changed the title
anvacaru
approved these changes
Apr 1, 2025
palinatolmach
approved these changes
Apr 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Blocked on: runtimeverification/k#4771Blocked on: runtimeverification/evm-semantics#2722Part of: #977
This PR generalizes the mechanism for including lemmas at prove time in the following ways:
rpc_argsare allowed to use--lemmasoption, which specifies a file/module to include new lemmas from, not justkontrol prove ....--extra-module(specific tokontrol prove ...) now gives a warning message that users should use--lemmas, and re-routes the option to that one.KGenOptionsintoBuildOptions, as it's the only place it's used now (since commandkontrol solc-to-k ...was removed).