506 refactor value handling #511
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dkcumming
approved these changes
Mar 27, 2025
Comment on lines
+440
to
+458
| // no value to return, skip writing | ||
| rule <k> #execTerminator(terminator(terminatorKindReturn, _SPAN)) ~> _ | ||
| => | ||
| #execBlockIdx(TARGET) | ||
| </k> | ||
| <currentFunc> _ => CALLER </currentFunc> | ||
| //<currentFrame> | ||
| <currentBody> _ => #getBlocks(FUNCS, CALLER) </currentBody> | ||
| <caller> CALLER => NEWCALLER </caller> | ||
| <dest> _ => NEWDEST </dest> | ||
| <target> someBasicBlockIdx(TARGET) => NEWTARGET </target> | ||
| <unwind> _ => UNWIND </unwind> | ||
| <locals> ListItem(_:NewLocal) _ => NEWLOCALS </locals> | ||
| //</currentFrame> | ||
| // remaining call stack (without top frame) | ||
| <stack> ListItem(StackFrame(NEWCALLER, NEWDEST, NEWTARGET, UNWIND, NEWLOCALS)) STACK => STACK </stack> | ||
| <functions> FUNCS </functions> | ||
| requires CALLER in_keys(FUNCS) | ||
| [preserves-definedness] // CALLER lookup defined |
There was a problem hiding this comment.
I am trying to think of what this looks like in the mir code. What is an example of this?
There was a problem hiding this comment.
The new rule is for the case where local _0 has not been written to (it is still sort NewLocal ) but the function returns. That happens regularly when a function returns nothing (i.e., unit). We used to "write" the noValue as a NoOp but now the sort is different so we should skip it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TypedLocalby subsortsTypedValue,NewLocal,MovedLocal(renaming constructors)Evaluationwith result sortTypedValueforOperandandRValueMIRErrorsort inhabited by all errors, and a labelled stop rule