Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor split RT-DATA into separate modules/files #515

Merged
merged 14 commits into from
Mar 31, 2025

Conversation

jberthold
Copy link
Member

@jberthold jberthold commented Mar 28, 2025

  • A basic module rt/value.md contains the Value sort and TypedLocal with its subsorts
  • A rt/numbers.md module contains code related to decoding and casting integers, and helper functions
  • The configuration now lives inside rt/configuration.md

Most of this is just moving existing code around into new files and adjusting imports.

The RT-DATA-LOW and RT-DATA-HIGH modules were removed, moving code from HIGH into RT-DATA (RT-DATA-LOW was never actually used).

New module import graph (omitting domains.md modules):

image

We can split rt/data.md into more parts, e.g.

  • reading/writing locals and projections,
  • Rvalue evaluation (in general), which could also move to KMIR-CONTROL-FLOW inside kmir.md
  • BinaryOp, UnaryOp (which are specific Rvalues)

@jberthold jberthold requested review from gtrepta and dkcumming and removed request for gtrepta March 28, 2025 05:46
@jberthold jberthold marked this pull request as ready for review March 28, 2025 05:46
Copy link
Collaborator

@dkcumming dkcumming left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@jberthold jberthold merged commit 94c1c78 into master Mar 31, 2025
5 checks passed
@jberthold jberthold deleted the REFACTOR-split-rt-data-into-modules branch March 31, 2025 02:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants