fix: notify errors immediately on async tasks - #56
Merged
Merged
Conversation
|
✅ All checks passed successfully! Ready to merge. |
rurreac
added a commit
that referenced
this pull request
Jan 30, 2026
* fix: proper notification handling on async console commands * chore: centralise values in configuration constants * fix: minor doc changes * fix: return command errors to main loop * fix: add mising * fix: lock history before writing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Async tasks weren't notifying errors immediately, instead relayed on a 10s timeout.
Now if an error is notified during the execution of an async task an error is return and control is returned to the console.
Also console command errors are handled at the main loop level.