Add "alloc" feature #71
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tcharding
force-pushed
the
07-28-alloc-feature
branch
from
89ce404 to
b6a963e
Compare
|
After reading through #45 I made some changes, primarily: make "std" enable "alloc" |
tcharding
force-pushed
the
07-28-alloc-feature
branch
from
b6a963e to
04b71a7
Compare
|
Might need some administration changes, this PR changes CI a bit and its now not running. Not exactly sure what needs doing to resolve. |
tcharding
force-pushed
the
07-28-alloc-feature
branch
from
04b71a7 to
3b57a4e
Compare
|
Changes in force push:
|
tcharding
force-pushed
the
07-28-alloc-feature
branch
from
3b57a4e to
e15eb28
Compare
|
Rebase only, no other changes. |
Ericson2314
approved these changes
Sep 28, 2022
tcharding
force-pushed
the
07-28-alloc-feature
branch
from
e15eb28 to
2cd7837
Compare
|
Rebased and improved test script. |
|
Gentle bump, can I get a review please crew. |
tcharding
force-pushed
the
07-28-alloc-feature
branch
from
2cd7837 to
f18b111
Compare
Merged
|
Needs rebase. |
tcharding
force-pushed
the
07-28-alloc-feature
branch
from
f18b111 to
4ab480c
Compare
|
Rebase only, no other changes. |
apoelstra
approved these changes
Feb 28, 2023
|
Needs rebase again. |
In preparation for adding a no-allocator embedded test crate; move the `embedded` crate (which uses a global allocator) to a subdirectory called `with-allocator`.
We would like users to be able to use parts of this library in a `no_std` environment without an allocator. To achieve this add an "alloc" feature and feature gate any code that requires allocation behind "alloc"/"std". Update the CI test job to run the test with each feature on its own.
In order to test that `bech32` can be built in a `no_std` environment without an allocator add a crate `no-allocator` to the `embedded` directory. Add a CI job to build the crate.
We now have two features that require testing in various combinations, add a `contrib/test.sh` script to do the testing and use it in the `Test` CI job. Add names to other steps in the job to improve clarity.
tcharding
force-pushed
the
07-28-alloc-feature
branch
from
4ab480c to
85caa28
Compare
|
Rebase only, no other changes. |
apoelstra
approved these changes
Mar 1, 2023
Closed
Closed
apoelstra
added a commit
that referenced
this pull request
Mar 1, 2023
7873c85 Rework GitHub actions (Tobin C. Harding) 433699f Enable alloc feature in with-allocator (Tobin C. Harding) Pull request description: Recently in #71 I introduced a bucket load of bugs, in CI and in the `with-allocator` crate (which was not being run correctly in CI). - Patch 1 enables the "alloc" feature in the `with-allocator` crate. - Patch 2 totally overhauls the github actions ACKs for top commit: apoelstra: ACK 7873c85 Tree-SHA512: ab8fbfd2dab315338c510b8622317d343186e62b78f5237ce8b4aceefc10963372c6238a114e244d03e0fe8fad2d4362c310be137c2af4ea057fb7020b46edf3
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We would like users to be able to use parts of this library in a
no_stdenvironment without an allocator. To achieve this add an "alloc" feature and feature gate any code that requires allocation behind.To test the new feature gating works, and catch regressions, add a crate that uses
bech32as a dependency with no default features and forces ano_stdbuild. (Does not test any code just imports the lib to verify it builds.)Patch 3 can be moved before patch 2 to verify that the crate does not currently build without an allocator.
Patch 4 adds a minimal
contrib/test.shscript.