-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add benchmarks #97
Add benchmarks #97
Conversation
a355a68
to
7dce69c
Compare
Needs rebase after #88. |
README.md
Outdated
## Benchmarks | ||
|
||
We use a custom Rust compiler configuration conditional to guard the bench mark code. To run the | ||
bench marks use: `RUSTFLAGS='--cfg=bench' cargo +nightly bench`. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In 692a12c:
I think "benchmark" should be one word (it's split up in two locations).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh yeah, good point.
ACK 7dce69c other than the merge conflicts. |
Rebased and fixed spelling of "benchmark" in the readme, no other changes. |
Add benchmarks for parsing and encoding bitcoin addresses. Also add two unit tests that parse the same address string used in the benchmarks. Specifically benchmark: - decoding an address - encoding an address with allocation - encoding an address without allocation Do so for both Bitcoin bech32 addresses and Bitcoin bech32m addresses.
We just added benchmarks to the crate, run them in CI when testing with the nightly toolchain.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK 34e6ab9
Add benchmarks for parsing and encoding bitcoin addresses. Also add two unit tests that parse the same address string used in the benchmarks.
Specifically benchmark:
Do so for both Bitcoin bech32 addresses and Bitcoin bech32m addresses.
Patch 1 is preparatory clean up to the readme.