Skip to content

Conversation

@nyonson
Copy link
Contributor

@nyonson nyonson commented Nov 7, 2025

Re-write the ci/run_task.sh script in xshell, attempting to match as much functionality as possible, but some user interfaces are changed for easier maintenance. The largest change is dropping the config scripts, contrib/crates.sh, contrib/whitelist_deps.sh, and contrib/test_vars.sh, for contrib/rbmt.toml.

The first patch makes the repo a workspace and initializes the new crate for the xshell based maintainer tools. The following patches add commands to match existing functionality. They also add a new lock command for lock file management as well as a --package filter (matching cargo's interface) to run commands on a subset of a workspace's crates.

Closes #25, #6

@nyonson
Copy link
Contributor Author

nyonson commented Nov 7, 2025

In draft mode for now, going to try and copy over all the existing tasks. Don't think it will be too difficult with the scaffolding done. Are we cool with the crate name and the binary name? Maybe I should add "rust-" to the front, but seemed weird publishing that to crates.

EDIT: convinced my self to just call it rust-bitcoin-maintenance-tools, rbmt for the exe.

@nyonson nyonson force-pushed the xshell branch 3 times, most recently from f0eeeb5 to 1d88466 Compare November 7, 2025 19:18
@nyonson nyonson force-pushed the xshell branch 2 times, most recently from 77a0be0 to 089c250 Compare November 7, 2025 22:19
@tcharding
Copy link
Member

tcharding commented Nov 9, 2025

This PR is sexy.

Unrelated, but for your amusement, while reviewing I was like "WTF is the releases crate" only to find

[package]
name = "releases"
version = "0.1.0"
authors = ["Tobin C. Harding <[email protected]>"]
license = "CC0-1.0"
repository = "https://github.com/rust-bitcoin/rust-bitcoin-maintainer-tools/"
description = "Tool for checking various release related things."

Guess I have not been running that ...

@tcharding
Copy link
Member

tcharding commented Nov 9, 2025

This was a pleasure to review. I spent most my time going, "yeah that looks right" as opposed to reviewing shell were I spend most my time going, "fuck, what exactly does that do, I think that's right but it might not be". Rust for the win.

@nyonson
Copy link
Contributor Author

nyonson commented Nov 9, 2025

Nice, I have 2 more patches for the test tasks and lockfiles, just ironing them out. I'll fold in these suggestions and push those up and should be close to good to go.

@nyonson nyonson force-pushed the xshell branch 2 times, most recently from ed1a787 to 3fdae1f Compare November 10, 2025 18:51
@nyonson nyonson marked this pull request as ready for review November 10, 2025 19:55
@nyonson
Copy link
Contributor Author

nyonson commented Nov 10, 2025

Added 5533a45 for a package filter feature. I think this is good to go, running it locally with rust-bitcoin. Still not quite sure yet the best way to integrate it (via cargo install or a dev-dep).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Re-write in xshell

3 participants