-
Notifications
You must be signed in to change notification settings - Fork 7
Re-write in xshell #26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
In draft mode for now, going to try and copy over all the existing tasks. Don't think it will be too difficult with the scaffolding done. Are we cool with the crate name and the binary name? Maybe I should add "rust-" to the front, but seemed weird publishing that to crates. EDIT: convinced my self to just call it |
f0eeeb5 to
1d88466
Compare
77a0be0 to
089c250
Compare
|
This PR is sexy. Unrelated, but for your amusement, while reviewing I was like "WTF is the [package]
name = "releases"
version = "0.1.0"
authors = ["Tobin C. Harding <[email protected]>"]
license = "CC0-1.0"
repository = "https://github.com/rust-bitcoin/rust-bitcoin-maintainer-tools/"
description = "Tool for checking various release related things."Guess I have not been running that ... |
|
This was a pleasure to review. I spent most my time going, "yeah that looks right" as opposed to reviewing shell were I spend most my time going, "fuck, what exactly does that do, I think that's right but it might not be". Rust for the win. |
|
Nice, I have 2 more patches for the |
ed1a787 to
3fdae1f
Compare
Match cargo's package filtering interface.
|
Added 5533a45 for a package filter feature. I think this is good to go, running it locally with rust-bitcoin. Still not quite sure yet the best way to integrate it (via cargo install or a dev-dep). |
Re-write the ci/run_task.sh script in xshell, attempting to match as much functionality as possible, but some user interfaces are changed for easier maintenance. The largest change is dropping the config scripts,
contrib/crates.sh,contrib/whitelist_deps.sh, andcontrib/test_vars.sh, forcontrib/rbmt.toml.The first patch makes the repo a workspace and initializes the new crate for the xshell based maintainer tools. The following patches add commands to match existing functionality. They also add a new
lockcommand for lock file management as well as a--packagefilter (matching cargo's interface) to run commands on a subset of a workspace's crates.Closes #25, #6