Added at_height and absolute_timelocks
#253
Conversation
There was a problem hiding this comment.
Some general comments about the PR:
In general, usually, PRs are rebased on top of the latest master to avoid conflicts. Looks like you are merging the master branch onto the PR branch. 1. Read https://www.atlassian.com/git/tutorials/merging-vs-rebasing for starters.
2. All commits in the PR should compile and pass the test. This helps tools like git bisect for easier debugging. The second commit in this PR
37a2ad28636fb4694672db88c0efebab393f8375 has incorrect tests which are later fixed in a follow commit.
3. The unused variable was introduced in the first commit and later fixed in the third commit. We should just not introduce it in the first commit.
|
The CI is broken right now, once #250 is fixed. I will add CI enforcement. |
|
Thanks for the suggestions. I've updated my master with the commits as suggested and have rebase-d it. |
src/policy/semantic.rs
Outdated
| /// Helper function for recursion in `absolute timelocks` | ||
| pub fn real_absolute_timelocks(&self) -> Vec<u32> { |
There was a problem hiding this comment.
nit: if this is a helper function, we'd rather not make it public?
There was a problem hiding this comment.
Ideally, this should be been fixed in cac7815 and not in the next commit, but it' okay :)
|
@SarcasticNastik, normally I wouldn't be so picky, but it would be a good exercise for you to try. Can you please make the change that Darosior requested? |
Related to #247 and #248 . Added the
at_heightfunction for analyzing policies andabsolute_timelocksfor semantic analysis.