Fix a bunch of clippy lints #627
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ha! linting like your a junior dev, thanks bro ... we need some junior devs around here. |
apoelstra
force-pushed
the
2023-11--clippy
branch
from
5a131ce to
fd1b352
Compare
|
CI is failing because of rust-lang/rust-clippy#11752. Will need to whitelist this lint. |
tcharding
approved these changes
Nov 3, 2023
|
If you were a junior dev I'd make you iterate on this one. Perhaps squash the whole thing into a single commit, you don't want all those commits in the index for ever :) (I'm still chuckling, the changes are all mixed up, random stuff in |
|
The CI fail is legit, just got an unused import in there. |
Also fixes a bunch of unused imports that are detected by the latest rustc nightly. (One is a wildcard import that actually imports nothing; the other are prelude things in a private prelude module.)
apoelstra
force-pushed
the
2023-11--clippy
branch
2 times, most recently
from
89dd79e to
1d70468
Compare
apoelstra
force-pushed
the
2023-11--clippy
branch
from
1d70468 to
7eccfdb
Compare
tcharding
approved these changes
Nov 3, 2023
|
cc @sanket1729 I think we need your ACK here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supercedes #615.