Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update MSRV to 1.56.1 #639

Merged
merged 1 commit into from
Feb 17, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/rust.yml
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@ jobs:
- rust: stable
- rust: beta
- rust: nightly
- rust: 1.48
- rust: "1.56.1"
steps:
- name: Checkout Crate
uses: actions/checkout@v2
Expand Down
5 changes: 3 additions & 2 deletions README.md
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
![Build](https://github.com/rust-bitcoin/rust-miniscript/workflows/Continuous%20integration/badge.svg)

**Minimum Supported Rust Version:** 1.48.0
**Minimum Supported Rust Version:** 1.56.1

# Miniscript

Expand Down Expand Up @@ -40,7 +40,8 @@ The cargo feature `std` is enabled by default. At least one of the features `std
Enabling the `no-std` feature does not disable `std`. To disable the `std` feature you must disable default features. The `no-std` feature only enables additional features required for this crate to be usable without `std`. Both can be enabled without conflict.

## Minimum Supported Rust Version (MSRV)
This library should always compile with any combination of features on **Rust 1.48.0**.

This library should always compile with any combination of features on **Rust 1.56.1**.

Some dependencies do not play nicely with our MSRV, if you are running the tests
you may need to pin some dependencies. See `./contrib/test.sh` for current pinning.
Expand Down
2 changes: 1 addition & 1 deletion clippy.toml
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
msrv = "1.48.0"
msrv = "1.56.1"
# plan API returns Self as an error type for an large-ish enum
large-error-threshold = 256
13 changes: 0 additions & 13 deletions contrib/test.sh
Original file line number Diff line number Diff line change
Expand Up @@ -20,19 +20,6 @@ then
cargo fmt -- --check
fi

# Pin dependencies required to build with Rust 1.48.0
if cargo --version | grep "1\.48\.0"; then
cargo update -p once_cell --precise 1.13.1
cargo update -p quote --precise 1.0.28
cargo update -p syn --precise 2.0.32
cargo update -p proc-macro2 --precise 1.0.63
cargo update -p serde_json --precise 1.0.99
cargo update -p serde --precise 1.0.152
cargo update -p log --precise 0.4.18
cargo update -p serde_test --precise 1.0.152
cargo update -p memchr --precise 2.5.0
fi

# Test bitcoind integration tests if told to (this only works with the stable toolchain)
if [ "$DO_BITCOIND_TESTS" = true ]; then
cd bitcoind-tests
Expand Down