-
Notifications
You must be signed in to change notification settings - Fork 148
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix compilation of pk()-only policies into tr() descriptors #677
Conversation
Thanks for the contribution! Can you put the unit test as a separate patch after the fix please so that during review I can swap them around and verify the failure. |
956f482
to
bb6347f
Compare
@tcharding Yes for sure, I updated my branch. |
Bother, the CI fail is unrelated to this PR. I hit the same thing elsewhere yesterday, I'll push a PR to fix it (it requires dependency pinning). |
I verified the unit test does indeed fail and the fix does fix the test. I have no view on the sanity of the change, requires @apoelstra or @sanket1729 who actually know this crate. I'm just the code monkey :) Thanks for the contribution. |
It's been a while since I looked at MSRV things. What is the current rust-bitcoin MSRV? The CI is failing at
|
Will need rebasing once #678 goes in. |
Prior to this fix, the test failed with: `Unexpected("Empty Miniscript compilation")`
bb6347f
to
ea3c523
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK ea3c523 successfully ran local tests; good find!
I'm gonna go ahead and merge this. My local tests pass and I've been recently reading this code (hence my breaking it :)) so I'm fairly confident I understand it. |
Pending a release with rust-bitcoin/rust-miniscript#677
Before this fix, the added test failed with:
Unexpected("Empty Miniscript compilation")