Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: Run fuzzer daily #683

Merged
merged 1 commit into from
May 2, 2024
Merged

CI: Run fuzzer daily #683

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
0 .github/workflows/fuzz.yml → .github/workflows/cron-daily-fuzz.yml
View file
Open in desktop
File renamed without changes.
3 changes: 2 additions & 1 deletion fuzz/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
[package]
name = "descriptor-fuzz"
edition = "2018"
edition = "2021"
rust-version = "1.56.1"
version = "0.0.1"
authors = ["Generated by fuzz/generate-files.sh"]
publish = false
Expand Down
27 changes: 14 additions & 13 deletions fuzz/generate-files.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,8 @@ source "$REPO_DIR/fuzz/fuzz-util.sh"
cat > "$REPO_DIR/fuzz/Cargo.toml" <<EOF
[package]
name = "descriptor-fuzz"
edition = "2018"
edition = "2021"
rust-version = "1.56.1"
version = "0.0.1"
authors = ["Generated by fuzz/generate-files.sh"]
publish = false
Expand Down Expand Up @@ -40,13 +41,13 @@ done
cat > "$REPO_DIR/.github/workflows/fuzz.yml" <<EOF
# Automatically generated by fuzz/generate-files.sh
name: Fuzz

on:
push:
branches:
- master
- 'test-ci/**'
pull_request:
schedule:
# 5am every day UTC, this correlates to:
# - 11pm PDT
# - 7am CET
# - 5pm AEDT
- cron: '00 06 * * *'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is 6AM right?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to change this to 05 or update the comment above.
I know that this is "copy-pasta" left over from the another PR that I saw earlier that had both 06 and 6am

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep. (At least, that's how I read it.)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh woops, I changed the three bottom ones and missed the top one (not shown here). While investigating I noticed that I totally botched this PR, I didn't change the output file to cron-fuzz-daily.yml and I didn't run the script either - god damn, it is hard to get good help. Will follow up.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Man, now I'm confused. A job cron-daily-fuzz ran last night.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, I must have created the yaml file manually and not run generate-files.sh - face palm.

Copy link
Member Author

@tcharding tcharding May 2, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#684

Thanks for finding by bugs @storopoli!

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm also confused -- I ran the script locally and the diff was clean (didn't even create any other files). Are you saying it did nothing?

Copy link
Member Author

@tcharding tcharding May 3, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems its too early in the morning for my brain to context switch back into this properly but if you check cron-daily-fuzz.sh you will ask yourself "who wrote this rubbish and how did it get in master?" For example it still runs on pull_request - all fixed in #684. As for postmortem I'm not sure how I botched it so badly.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I must have tested the fuzz script in a different repo or something. This is definitely broken as hell :).


jobs:
fuzz:
Expand All @@ -55,26 +56,26 @@ jobs:
strategy:
fail-fast: false
matrix:
# We only get 20 jobs at a time, we probably don't want to go
# over that limit with fuzzing because of the hour run time.
fuzz_target: [
$(for name in $(listTargetNames); do echo "$name,"; done)
]
steps:
- name: Install test dependencies
run: sudo apt-get update -y && sudo apt-get install -y binutils-dev libunwind8-dev libcurl4-openssl-dev libelf-dev libdw-dev cmake gcc libiberty-dev
- uses: actions/checkout@v2
- uses: actions/cache@v2
- uses: actions/checkout@v4
- uses: actions/cache@v4
id: cache-fuzz
with:
path: |
~/.cargo/bin
fuzz/target
target
key: cache-\${{ matrix.target }}-\${{ hashFiles('**/Cargo.toml','**/Cargo.lock') }}
- uses: actions-rs/toolchain@v1
- uses: dtolnay/rust-toolchain@stable
with:
toolchain: '1.65'
override: true
profile: minimal
toolchain: '1.65.0'
- name: fuzz
run: cd fuzz && ./fuzz.sh "\${{ matrix.fuzz_target }}"
- run: echo "\${{ matrix.fuzz_target }}" >executed_\${{ matrix.fuzz_target }}
Expand Down
Loading