ci: shellcheck checks #689
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tcharding
approved these changes
May 19, 2024
Comment on lines
+10
to
+11
| # can't find the file because of the ENV var | ||
| # shellcheck source=/dev/null |
There was a problem hiding this comment.
Why do you silence this like this man instead of?
# shellcheck disable=SC1090
(I hit the same warning working on rust-bitcoin/rust-secp256k1#699.)
There was a problem hiding this comment.
It was the same approach I did in the original rust-bitcoin PR and this is the way to adopt a Exception per the shellcheck wiki: https://www.shellcheck.net/wiki/SC1090
|
Can you please rebase this? It is currently based on a version of rust-miniscript from February (prior to the rust-bitcoin upgrade) and my local lockfiles have changed a lot since then. (This should become less of a problem soon once we bring lockfiles into the repo itself.) |
|
@apoelstra done |
apoelstra
approved these changes
May 20, 2024
tcharding
approved these changes
May 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following rust-bitcoin/rust-bitcoin#2762,
adding CI shellcheck cheks here as well.
I also did all fixes that I could find with
If I've missed any please let me know.