Demonstrate usage of new bitcoind-json-rpc repo #692
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Demo use of the new repo, has bugs in amount parsing somewhere but I wanted to push this up before the weekend.
sanket1729
reviewed
Jun 7, 2024
|
Thanks for looking. Do you use rust analyzer? I don't, but had the thought this morning that the new client and test crate might be brutal for rust analyzer to handle, I vaguely remember it not working so well with macos. |
|
Superseded by #694 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Demo use of the new repo, has bugs in amount parsing somewhere but I wanted to push this up before the weekend.
Uses: https://github.com/tcharding/rust-bitcoind-json-rpc
Introduces testing against bitcoind versions
v26.0v25.2v25.1v25.0v24.2v24.1v24.0.1v23.2v23.1v23.0v22.1v22.0v0.21.2v0.20.2v0.19.1v0.18.1v0.17.1