Patch the bitcoin_hashes dependency #575
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently we have a hole in our dependency graph that is making it
impossible to patch `bitcoin_hashes` with breaking changes.
bitcoin -> secp -> hashes
-> hashes
Make `secp256k1` depend on the first commit that imported
`bitcoin_hashes` into `rust-bitcoin`. No code changes required.
With this applied, when patching `hashes` with a breaking change,
we will be able to build the code still.
Depend on the commit from current master branch of `rust-bitcoin` for the `bitcoin_hashes` dependency. Requires a change to dereference using `as_ref` to get a reference to a byte slice.
This was referenced Jan 28, 2023
|
Needs to go on top of #576 |
|
Closing because we have a better approach: rust-bitcoin/rust-bitcoin#1553 (comment) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently we have a hole in our dependency graph that is making it impossible to patch
bitcoin_hasheswith breaking changes.bitcoin -> secp -> hashes
bitcoin -> hashes
Make
secp256k1depend on a dev version ofhashes- done as two separate patches, one for the initial import ofhashesintorust-bitcoinand one for the current version.With this applied, when patching
hasheswith a breaking change, we will be able to build the code still.