Pin wasm #787
Open
Pin wasm #787
+7
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
So far testing was was done unpinned however that risked randomly breaking builds whenever a dependency changes by accident. There was a note explicitly acknowledging lack of pinning but with no explanation why that was the case. So it might be because the author didn't want to bother and pinning can be implemented.
As with anything else, downloading a random version from crates risks breaking CI. This change decreases the risk by pinning the crate but so far makes *no attempts* at trying to update it in a cron job. It would be definitely a nice addition later.
|
Reminder that rustwasm/wasm-pack#1316 means that no matter how much you try to pin tooling, |
|
@apoelstra no, read the actual code. It does pass arguments (such as (Of course, if anyone is running |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An attempt to solve the wasm CI issue. (But even if unsuccessful, this is still useful.)