Put back in deprecated context methods #872
Open
+211
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
EDIT: I was off my head yesterday.
|
|
Tested using rust-bitcoin/rust-bitcoin#5169 |
|
EDIT: I was off my head yesterday.
|
tcharding
force-pushed
the
push-qwxzzztsrosw
branch
from
9d7a33f to
0300949
Compare
During the removal of the context from the public API I brashly deleted a bunch of impls on the `Secp256k1` type when we could have just deprecated them. This means that when upgrading downstream crates the upgrade is way more painful than it is if we deprecate. Add back in the context impls. To do this I copied from `v0.31.1`. I'm not totally sure that there wasn't changes to this code in `master` but since we are explicitly doing this to help upgrade then it seems reasonable to do it like this. Add deprecated since 0.32 attributes because we are going to push this as a `0.32.0-beta.1` release. Sorry for the pain in reviewing this, I'm not entirely sure how you are supposed to convince yourself that the code is exactly as it was?
tcharding
force-pushed
the
push-qwxzzztsrosw
branch
from
0300949 to
3815ee6
Compare
Typing `just update-lock-files` is boring, add an alias.
We just added the secp context methods back in (deprecated) to make upgrading easier. In preparation for release, bump the version, add a note in the changelog, and update the lock files.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During the removal of the context from the public API I brashly deleted a bunch of impls on the
Secp256k1type when we could have just deprecated them. This means that when upgrading downstream crates the upgrade is way more painful than it is if we deprecate.Add back in the context impls. Call through to the new API.