Skip to content

Hash-pin some actions, eliminate some credentials#311

Closed
woodruffw wants to merge 3 commits intorust-cli:mainfrom
woodruffw-forks:ww/ci-chores
Closed

Hash-pin some actions, eliminate some credentials#311
woodruffw wants to merge 3 commits intorust-cli:mainfrom
woodruffw-forks:ww/ci-chores

Conversation

@woodruffw
Copy link
Copy Markdown

This burns down some findings from zizmor. The main ones are actions that aren't hash-pinned (I've fixed these with pinact run -v) and credential persistence by default in actions/checkout. There's one place (template.yml) where the persisted credential was actually being used, so I've done persist-credential: true there.

Apart from that, I've removed one (probably not exploitable) template injection. There are about 41 other remaining zizmor issues, but a good chunk of those are superfluous-actions (which should get suppressed on the next release per zizmorcore/zizmor#1817). I haven't added a zizmor workflow with this PR, but would be happy to either here or in a follow-up if desired.

(N.B. a lot of the actions that are left unpinned are left because they require a maintenance decision, e.g. replacing uses: taiki-e/install-action@cargo-hack with uses: taiki-e/install-action@hash.... and tool: cargo-hack@v1.2.3. If that's fine by you, I can do those in a follow-up too.)

Signed-off-by: William Woodruff <william@yossarian.net>
Primarily two auto-fixes: disabling
credential persistence for the checkout action,
and removing a small template injection.

Signed-off-by: William Woodruff <william@yossarian.net>
Signed-off-by: William Woodruff <william@yossarian.net>
@woodruffw
Copy link
Copy Markdown
Author

Oops, realized I forgot to put my motivation in the top comment: I'm opening these kinds of PRs across a few repos hosting crates that uv and other Astral tools depend on, as part of our goal to ratchet down sources of mutability/supply chain risk in our downstream. But if you find this disruptive, I'd be happy to close this.

epage added a commit to epage/_rust that referenced this pull request Apr 6, 2026
@epage
Copy link
Copy Markdown
Collaborator

epage commented Apr 6, 2026

I have a central template (https://github.com/epage/_rust) thati s a merge base for all of my repos. I recently adopted zizmor there (which is why I've been opening issues and PRs) and have been working out some kinks before mass updating all of my repos.

I would prefer to adopt this change in the template update.

@woodruffw
Copy link
Copy Markdown
Author

Oh whoops, that explains a lot. I can move these proposed changes over there.

@epage
Copy link
Copy Markdown
Collaborator

epage commented Apr 6, 2026

Sure, any further improvements would be appreciated.

@woodruffw woodruffw closed this Apr 6, 2026
@woodruffw woodruffw deleted the ww/ci-chores branch April 6, 2026 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants