This repository was archived by the owner on Mar 29, 2025. It is now read-only.
Use CUDA_PATH on Windows to find Cuda #6
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The "10.0-devel-ubuntu16.04" run looks like noise. Could you re-run it? |
|
Hey @bheisler, do you have any feedback on this change? |
|
Seems reasonable to me. The CUDA_PATH variable is set on my machine. |
|
Oh, heh, sorry. I had assumed you were the maintainer of this repo. |
|
Ah, no, I don't have write access so I can't merge this pull request. I believe @termoshtt would have access. |
…variable CUDA_PATH when CUDA_LIBRARY_PATH is not set
AndrewGaspar
force-pushed
the
find-std-windows-install
branch
from
ac91f72 to
702944c
Compare
termoshtt
approved these changes
Jan 6, 2019
|
👍 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change to the build script searches in
CUDA_PATHfor Cuda when targeting Windows whenCUDA_LIBRARY_PATHis not set.CUDA_PATHis set in the typical Cuda install on Windows, so this change makes it easier to usecuda-sysand derived crates on Windows, without having to do anything beyond installing Cuda.I tried to support building for 32-bit Windows. Nvidia does not ship 32-bit builds for
cublas.lib, whichcuda-syscurrently requires. The code is still there, though, in case this requirement is relaxed.