Remove const-fn feature #25
Conversation
Cargo.toml
Outdated
| @@ -7,10 +7,7 @@ keywords = ["bare-metal", "register", "peripheral", "interrupt"] | |||
| license = "MIT OR Apache-2.0" | |||
| name = "bare-metal" | |||
| repository = "https://github.com/rust-embedded/bare-metal" | |||
| version = "0.2.5" | |||
| version = "0.3.0" | |||
There was a problem hiding this comment.
Please don't bump the version in otherwise unrelated PRs, or we might bump it again when doing the next release
There was a problem hiding this comment.
Sure. I can undo that. Just a habit when making breaking changes.
build.rs
Outdated
|
|
||
| fn main() { | ||
| let vers = rustc_version::version().unwrap(); | ||
|
|
||
| if vers.major == 1 && vers.minor < 31 { | ||
| println!("cargo:rustc-cfg=unstable_const_fn") | ||
| eprintln!("cargo:crate requires rust >= 1.31"); | ||
| exit(1); |
There was a problem hiding this comment.
I'm not sure this is the right way to go about this.
As best as I can tell, Cargo has not implemented a way to specify minimum rust version yet.
rust-lang/rust#65262
There was a problem hiding this comment.
Why don't we just remove this?
There was a problem hiding this comment.
Can do. Just seemed nicer than potentially cryptic compiler errors.
I’ll just remove build.rs entirely then.
|
@jonas-schievink seems like it, yes. I would appreciate feedback on what I did in |
|
bors r+ |
Build succeeded |
Per #22, as of Rust v1.31 const-fn was stablized.
Removing the feature in preparation of a 1.0 release.
Related to #11