Separate Capture, Pwm and Qei traits into modules #195
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eldruin
requested review from
ilya-epifanov,
thejpster and
a team
as code owners
|
r? @ryankurte (rust_highfive has picked a reviewer for you, use r? to override) |
|
Seems like a good idea to me!
As part of the breaking changes happening in #192 I think we may as well fix this for consistency. |
eldruin
force-pushed
the
separate-traits
branch
from
f0bd024 to
60c9263
Compare
|
@ryankurte sorry there were some errors in the documentation. They should be solved now. |
|
Is anything preventing this being merged? |
ryankurte
approved these changes
Apr 2, 2020
|
thanks for the reminder, looks good to me (though we're going to need to do a lot of changelog updating) bors r+ |
Build succeeded |
bors bot
added a commit
that referenced
this pull request
Apr 4, 2020
196: Document moved traits in changelog r=ryankurte a=eldruin This was missing in #195. Co-authored-by: Diego Barrios Romero <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
lib.rsfile is already very long. I propose separating these traits which are just at the end of the file into their own modules.I have kept the modules private and reexported the traits and types to maintain the same interface.
However, for consistency with the other traits maybe it would be worth it to expose these new modules as well and not reexport the traits in
lib.rs.What do you think?