202411 #8
Draft
202411 #8
+2,637
−857
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…erver 0.1.33, once_cell 1.21.3, windows-core 0.61.0; 新しいパッケージを追加: getrandom 0.3.2, r-efi 5.2.0, wasi 0.14.2+wasi-0.2.4, windows-implement 0.60.0, windows-interface 0.59.1, windows-result 0.3.2, windows-strings 0.4.0, wit-bindgen-rt 0.39.0
There was a problem hiding this comment.
Pull Request Overview
This PR updates the Rust edition to 2024, upgrades multiple dependency versions, and refines GitHub workflow configurations.
- Updated Cargo.toml files in the main project and xtask to use the 2024 edition and newer dependency versions.
- Adjusted dependency version constraints and licensing clarifications in deny.toml and clarify.toml.
- Upgraded GitHub workflow runner versions and checkout actions, and enhanced the build matrix in build.yml.
Reviewed Changes
Copilot reviewed 12 out of 16 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| xtask/Cargo.toml | Changed Rust edition to 2024 and updated several dependency versions. |
| deny.toml | Updated build script allowances and bumped dependency versions. |
| clarify.toml | Expanded and refined license expressions and file mappings. |
| Cargo.toml | Upgraded edition and dependency versions, including switching to a git ref. |
| .github/workflows/*.yml | Updated runner images, checkout actions, and build matrix configurations. |
Files not reviewed (4)
- Dockerfile: Language not supported
- rust-toolchain: Language not supported
- xtask/templates/install-command.bash.txt: Language not supported
- xtask/templates/install-script.toml.txt: Language not supported
Comments suppressed due to low confidence (4)
Cargo.toml:22
- [nitpick] Consider removing the commented-out version of ac-library-rs to avoid potential confusion with the new git dependency specification.
ac-library-rs = { git = "https://github.com/rust-lang-ja/ac-library-rs", rev = "eea0b2ac6b177fc09b706b4e727b3e62e6ef30e7" }
Cargo.toml:35
- Verify that the upgrade to amplify v4.8.0 is fully compatible with the existing codebase, as version changes may bring breaking changes.
amplify = { version = "=4.8.0", features = ["c_raw", "rand", "stringly_conversions"] }
.github/workflows/typos.yml:8
- Confirm that the upgrade to ubuntu-24.04 as the runner does not introduce compatibility issues with the actions used.
runs-on: ubuntu-24.04
.github/workflows/licenses.yml:26
- Ensure that cargo-deny v0.16 does not introduce any configuration or behavior changes that may affect license checks.
run: cargo binstall cargo-deny@^0.16 --no-confirm --log-level debug
| - { target: x86_64-apple-darwin, os: macos-11 } | ||
| - { target: x86_64-apple-darwin, os: macos-12 } | ||
| - { target: x86_64-unknown-linux-gnu, os: ubuntu-20.04 } | ||
| - { target: x86_64-pc-windows-msvc, os: windows-2025 } |
There was a problem hiding this comment.
Ensure that the specified runner 'windows-2025' is available and supported by GitHub Actions to prevent build failures.
Suggested change
| - { target: x86_64-pc-windows-msvc, os: windows-2025 } | |
| - { target: x86_64-pc-windows-msvc, os: windows-2022 } |
Copilot is powered by AI, so mistakes are possible. Review output carefully before use.
…に更新; 新しいパッケージallocator-api2 0.2.21とfoldhash 0.1.5を追加; indexmapを2.9.0、petgraphを0.8.0、smallvecを1.15.0に更新; deny.tomlにZlibライセンスを追加
…-rsのリビジョンを032ef62edcdd024657f847461e33c084520235dfに更新
…を1.2.19に、clapを4.5.36に、clap_builderを4.5.36に、libcを0.2.172に、proc-macro2を1.0.95に更新
…4cc463に更新; randを0.9.1に更新
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.