Improve error when versions start with v

[DeveloperC286]

Fixes #12331

[rustbot]

r? @epage

rustbot has assigned @epage.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

[DeveloperC286]

While working on this I have the questions

1. Do we want to standardise the error messages for the same error across the commands?
2. Do we want to support a v in a version range?

[epage]

Do we want to standardise the error messages for the same error across the commands?

We should be consistent where it makes sense

Do we want to support a v in a version range?

As in not error? This was discussed in the issue and the issue is currently scoped to just improving the error messages. If there is a reason to reconsider that, the case should be made in the issue. We should probably still move forward with this PR.

[weihanglo]

@DeveloperC286
I believe what Ed said is backing out the support of v prefix in this PR. That part is still in discussion. We should focus on improving the error messages in this PR.

[DeveloperC286]

Oh okay, I got my wires crossed somewhere. I thought there was support for handing versions prefixed with 'v'.

While a version prefixed with a v is not strictly a semantic version it is commonly used, e.g. output by automated release tooling etc, so not supporting it just makes it harder to integrate with other tools.

I'm not sure I see the point if I run cargo install [email protected] of an error message saying did you mean 'cargo... @0.5.0'?. I think if your able to produce an error message that clear then the intent is clear and if the intent is clear I don't see the point in being pedantic and not just doing it.

[epage]

Please see my earlier comment at #15259 (comment)

[DeveloperC286]

I only have limited free time ATM and was doing this piecemeal, I think reworking this PR to just improved error messages takes me back basically to the start. Someone feel free to take this over, I will close this as I don't have the time ATM.