fix(script): surpress unused_features lint for embedded#16714
Merged
epage merged 1 commit intorust-lang:masterfrom Mar 6, 2026
Merged
fix(script): surpress unused_features lint for embedded#16714epage merged 1 commit intorust-lang:masterfrom
unused_features lint for embedded#16714epage merged 1 commit intorust-lang:masterfrom
Conversation
rust-lang/rust#152164 added a warn-by-default `unused_features` lint. Cargo injects `#![feature(frontmatter)]` for all embedded scripts, but scripts without frontmatter syntax never trigger feature gate check, and causes causing the lint warning. Given the stabilization FCP of frontmatter is complete already, we could expect it will soon be stabilized (?). It should be finewe suppress this new unstable lint.
rustbot
added
A-build-execution
Collaborator
|
r? @epage rustbot has assigned @epage. Use Why was this reviewer chosen?The reviewer was selected based on:
|
epage
approved these changes
Mar 6, 2026
rustbot
removed
the
S-waiting-on-review
ehuss
pushed a commit
to ehuss/cargo
that referenced
this pull request
Mar 6, 2026
…16714) ### What does this PR try to resolve? rust-lang/rust#152164 added a warn-by-default `unused_features` lint. Cargo injects `#![feature(frontmatter)]` for all embedded scripts, but scripts without frontmatter syntax never trigger feature gate check, and causes causing the lint warning. Given the stabilization FCP of frontmatter [is complete](rust-lang/rust#148051 (comment)) already, we could expect it will soon be stabilized (?). It should be fine we suppress this new unstable lint. ### How to test and review this PR? Test suite passes. See <rust-lang#16713 (comment)> for more.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR try to resolve?
rust-lang/rust#152164 added a warn-by-default
unused_featureslint.Cargo injects
#![feature(frontmatter)]for all embedded scripts,but scripts without frontmatter syntax never trigger feature gate check,
and causes causing the lint warning.
Given the stabilization FCP of frontmatter is complete already,
we could expect it will soon be stabilized (?).
It should be fine we suppress this new unstable lint.
How to test and review this PR?
Test suite passes.
See #16713 (comment) for more.