feat(toml): allow overriding inherited default-features in 2024 by 0xPoe · Pull Request #17126 · rust-lang/cargo

0xPoe · 2026-06-21T22:15:37Z

What does this PR try to resolve?

Implement RFC 3945, on Edition 2024+ allow workspace members to override the workspace dependency's default-features setting.

Earlier editions are unchanged: setting default-features on an inherited dependency is still ignored with a warning.

Also, this change would allow cargo add X --no-default-features -p Y, but only on Edition 2024+.

How to test and review this PR?

Review and check it commit by commit.

r?@ghost

0xPoe

cargo add dep --default-features -p app doesn't work correctly. I will rework this.

View changes since this review

epage · 2026-06-23T22:38:56Z

Will we need to update https://doc.rust-lang.org/edition-guide/rust-2024/cargo-inherited-default-features.html as part of this?

0xPoe · 2026-06-24T22:11:17Z

Will we need to update doc.rust-lang.org/edition-guide/rust-2024/cargo-inherited-default-features.html as part of this?

Yes, I will create a PR for this.

0xPoe

🔢 Self-check (PR reviewed by myself and ready for feedback)

Code compiles successfully
Unit tests added
No AI-generated elegant nonsense in PR.
Comments added where necessary
PR title and description updated
Documentation updated
PR size is reasonable

View changes since this review

0xPoe · 2026-06-24T22:31:16Z

+- [`default-features`][default-features] (Edition 2024 packages, requires Rust 1.98+):
+  Overrides the value set in `[workspace.dependencies]`.
+  If neither the package nor the workspace specifies `default-features`, it defaults to `true`.
+  Before Rust 1.98, or in earlier editions, package-level `default-features = false`


Not sure if this is the perfect word for it, and not sure how detailed we should be here.

rust-rfcbot · 2026-07-28T14:12:25Z

🔔 This is now entering its final comment period, as per the review above. 🔔

rust-rfcbot · 2026-08-07T14:12:57Z

The final comment period, with a disposition to merge, as per the review above, is now complete.

As the automated representative of the governance process, I would like to thank the author for their work and everyone else who contributed.

epage

Thanks!

View changes since this review

epage · 2026-08-07T16:01:43Z

Looks like some tests need updating

Impl RFC 3945, on Edition 2024+ allow workspace members to override the workspace dependency's `default-features` setting. Earlier editions are unchanged: setting `default-features` on an inherited dependency is still ignored with a warning. Signed-off-by: 0xPoe <techregister@pm.me>

Signed-off-by: 0xPoe <techregister@pm.me>

`cargo add --no-default-features` (or `--default-features`) against a dependency inherited from `[workspace.dependencies]` is now allowed when the package is on Edition 2024+, matching the manifest behavior. Earlier editions still error, pointing the user to the workspace manifest. Signed-off-by: 0xPoe <techregister@pm.me>

Signed-off-by: 0xPoe <techregister@pm.me>

rustbot · 2026-08-07T20:20:53Z

This PR was rebased onto a different master commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

0xPoe · 2026-08-07T20:21:49Z

Looks like some tests need updating

Updated. See changes at: #17126 (comment)

0xPoe · 2026-08-07T22:48:00Z

Thanks for your review! 💚 💙 💜 💛 ❤️

0xPoe · 2026-08-07T22:48:58Z

Will we need to update doc.rust-lang.org/edition-guide/rust-2024/cargo-inherited-default-features.html as part of this?

Yes, I will create a PR for this.

I will handle this tomorrow.

rustbot added A-documenting-cargo-itself Area: Cargo's documentation A-manifest Area: Cargo.toml issues Command-add labels Jun 21, 2026

0xPoe force-pushed the poe-patch-inherit-default-features branch 3 times, most recently from 72f4119 to 62db596 Compare June 23, 2026 21:34

0xPoe marked this pull request as ready for review June 23, 2026 21:34

rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jun 23, 2026

0xPoe changed the title ~~NOT READY FOR REVIEW: feat(toml): allow overriding inherited default-features in 2024~~ feat(toml): allow overriding inherited default-features in 2024 Jun 23, 2026

0xPoe commented Jun 23, 2026

View reviewed changes

rustbot assigned weihanglo Jun 23, 2026

0xPoe marked this pull request as draft June 23, 2026 22:02

rustbot removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jun 23, 2026

0xPoe changed the title ~~feat(toml): allow overriding inherited default-features in 2024~~ WIP: feat(toml): allow overriding inherited default-features in 2024 Jun 23, 2026

epage approved these changes Jun 23, 2026

View reviewed changes

Comment thread src/cargo/util/toml/mod.rs Outdated

Comment thread src/doc/src/reference/workspaces.md Outdated

0xPoe force-pushed the poe-patch-inherit-default-features branch 3 times, most recently from f2f677f to 17595ac Compare June 24, 2026 22:04

0xPoe marked this pull request as ready for review June 24, 2026 22:11

rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jun 24, 2026

0xPoe changed the title ~~WIP: feat(toml): allow overriding inherited default-features in 2024~~ feat(toml): allow overriding inherited default-features in 2024 Jun 24, 2026

0xPoe force-pushed the poe-patch-inherit-default-features branch 2 times, most recently from 33ca750 to 1b14f50 Compare June 24, 2026 22:32

0xPoe commented Jun 24, 2026

View reviewed changes

0xPoe requested a review from epage June 25, 2026 13:56

epage reviewed Jun 30, 2026

View reviewed changes

Comment thread src/workspace/editor/dependency.rs

epage reviewed Jun 30, 2026

View reviewed changes

Comment thread src/cargo/util/toml/mod.rs Outdated

0xPoe force-pushed the poe-patch-inherit-default-features branch from e97fffa to 62a3dd8 Compare June 30, 2026 19:24

rust-rfcbot removed the proposed-final-comment-period An FCP proposal has started, but not yet signed off. label Jul 28, 2026

coderabbitai Bot mentioned this pull request Jul 30, 2026

Serialization voxell-tech/motiongfx#124

Merged

rust-rfcbot added finished-final-comment-period FCP complete to-announce and removed final-comment-period FCP — a period for last comments before action is taken labels Aug 7, 2026

epage approved these changes Aug 7, 2026

View reviewed changes

epage added this pull request to the merge queue Aug 7, 2026

github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Aug 7, 2026

0xPoe added 7 commits August 7, 2026 22:18

test(add): add inherit no default features case

4fcaf04

Signed-off-by: 0xPoe <techregister@pm.me>

test(add): add inherit default features case

71d2857

Signed-off-by: 0xPoe <techregister@pm.me>

fix(add): set dep's default features explicitly

c74cbfe

Signed-off-by: 0xPoe <techregister@pm.me>

fix(add): update outdated warnings

31a5365

Signed-off-by: 0xPoe <techregister@pm.me>

docs: document overriding inherited default-features

945b29c

Signed-off-by: 0xPoe <techregister@pm.me>

0xPoe force-pushed the poe-patch-inherit-default-features branch from 677fb45 to 945b29c Compare August 7, 2026 20:20

0xPoe enabled auto-merge August 7, 2026 20:22

0xPoe added this pull request to the merge queue Aug 7, 2026

Merged via the queue into rust-lang:master with commit 8f92105 Aug 7, 2026
31 checks passed

0xPoe deleted the poe-patch-inherit-default-features branch August 7, 2026 21:37

rustbot removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Aug 7, 2026

weihanglo mentioned this pull request Aug 7, 2026

Update cargo submodule rust-lang/rust#160727

Open

Uh oh!

Uh oh!

Conversation

0xPoe commented Jun 21, 2026 • edited by rustbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What does this PR try to resolve?

How to test and review this PR?

Uh oh!

0xPoe left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

epage commented Jun 23, 2026

Uh oh!

Uh oh!

Uh oh!

0xPoe commented Jun 24, 2026

Uh oh!

0xPoe left a comment • edited by rustbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

0xPoe Jun 24, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

rust-rfcbot commented Jul 28, 2026

Uh oh!

rust-rfcbot commented Aug 7, 2026

Uh oh!

epage left a comment • edited by rustbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

epage commented Aug 7, 2026

Uh oh!

rustbot commented Aug 7, 2026

Uh oh!

0xPoe commented Aug 7, 2026

Uh oh!

Uh oh!

0xPoe commented Aug 7, 2026

Uh oh!

0xPoe commented Aug 7, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

0xPoe commented Jun 21, 2026 •

edited by rustbot

Loading

0xPoe left a comment •

edited

Loading

0xPoe left a comment •

edited by rustbot

Loading

epage left a comment •

edited by rustbot

Loading