Add support for targets like x86_64-unknown-linux-gnu-asan #1629
+25
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently we are not able to create targets that have specific sanitizers enabled by default, since having five components gives: ``` cc-rs: too many components in target x86_64-unknown-linux-gnu-asan ``` This allows currently parsing such targets and simply strips the final part before turning it into a `TargetInfo`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently we are not able to create targets that have specific sanitizers enabled by default, since having five components gives:
This allows currently parsing such targets and simply strips the final part before turning it into a
TargetInfo.I'm opening this since I was suggested to use
x86_64-unknown-linux-gnu-asanas the appropriate name for the target I'm creating (context: rust-lang/rust#149644 (comment)).However I'd love to get some input on how we can solve this in the best way.
Right now I'm basically just throwing away the 5th component. Should we also parse this into the TargetInfo, do we want this sanitizer specific or give this a more generic name?
I'm opening this to hopefully get some input on what the most desirable way to solve this is. Thank you!