Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add Git commit sha to container labels #165

Merged
merged 4 commits into from
Feb 5, 2025

Conversation

mayocream
Copy link
Contributor

@mayocream mayocream changed the title chore: add Git commit sha to container tags chore: add Git commit sha to container labels Feb 3, 2025
@syphar syphar merged commit 1e19333 into rust-lang:master Feb 5, 2025
3 checks passed
@syphar
Copy link
Member

syphar commented Feb 5, 2025

@mayocream It seems like now we're missing the latest label: https://github.com/rust-lang/crates-build-env/pkgs/container/crates-build-env%2Flinux-micro

and we only see master instead of a git SHA

you have time to fix this? Otherwise I'll revert

@mayocream
Copy link
Contributor Author

@mayocream It seems like now we're missing the latest label: https://github.com/rust-lang/crates-build-env/pkgs/container/crates-build-env%2Flinux-micro

and we only see master instead of a git SHA

you have time to fix this? Otherwise I'll revert

Oh sorry for that, will create a follow up PR soon.

@syphar
Copy link
Member

syphar commented Feb 5, 2025

Ah, now I see that in the manifest we have specific labels that represent git SHA etc, which is fine

@syphar
Copy link
Member

syphar commented Feb 5, 2025

the general latest label would be still good :)

@mayocream
Copy link
Contributor Author

the general latest label would be still good :)

created #167

@mayocream mayocream deleted the patch-1 branch February 5, 2025 05:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants