Add rustdoc JSON download endpoints & about-page #2832
Merged
+334
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
S-waiting-on-review
GuillaumeGomez
approved these changes
May 24, 2025
|
Code looks good, thanks! Just to confirm: it doesn't add a button to download the JSON right? |
|
Nope, no button, only documentation, similar to the archive download. Do you feel like we should add a button? Now or later? |
|
Let's do it later. We need to discuss where to put this link/button etc. |
github-actions
bot
added
S-waiting-on-deploy
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #1285
note: all old json builds before #2829 didn't have public access enabled. I fixed that with a small script on the server, so we don't need to have the handler fix this like in the archive-download endpoint.