Use dynamic lookup to prevent Enzyme from embedding its own copy of LLVM on APPLE#31
Use dynamic lookup to prevent Enzyme from embedding its own copy of LLVM on APPLE#31sgasho wants to merge 6 commits intorust-lang:mainfrom
Conversation
Co-authored-by: Lorenz Schmidt <bytesnake@mailbox.org> Co-authored-by: Jed Brown <jed@jedbrown.org> Co-authored-by: William Moses <gh@wsmoses.com>
* Add Rust CI * Use ccache * Limit matrix * Disable macos for now
sgasho
changed the title
|
This change is only for std::autodiff, so I think this PR should be here, not in the upstream(EnzymeAD/Enzyme) |
|
I'd offer to upstream it later (probably under an extra flag), since there could be Enzyme users with a similar setup to us. From previous discussions, I remember we shouldn't need 09f4820 anymore, now that we're libloading Enzyme, right? Can you please add a revert of 09f4820 as the first commit to your PR, and then apply your patches? If we can create working linux and macos artifacts with that branch, I can (finally) drop it from our fork. |
sgasho
force-pushed
the
disable-static-linking-llvm-apple
branch
from
cfeb2d0 to
123ab0b
Compare
|
Yes, I reverted 09f4820 and confirmed autodiff works fine using CI tarballs at the PR rust-lang/rust#151063
Yes, I did it and force-pushed! |
|
I think I can close this because the commit below includes dynamic lookup on APPLE |
3 participants
rustc already embeds LLVM and having two copies of them can cause std::autodiff to hang.
dependencies: rust-lang/rust#151243
I need to update Enzyme submodule on r-l/r after merging this PR. you can merge rust-lang/rust#151243 after that.