Improve handling of function inlining a bit more #32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… when generating some code using target-specific builtins
…o allow recursive types
gcc/config/i386: PR jit/TODO * i386-builtins.cc: New function (clear_builtin_types). gcc/jit: PR jit/TODO * dummy-frontend.cc: Include headers target.h, jit-recording.h, unordered_map and string, new variables (target_function_types, and target_builtins_ctxt), new function (tree_type_to_jit_type). * jit-builtins.cc: Specify that the function types are not from target builtins. * jit-playback.cc: New argument is_target_builtin to new_function. * jit-playback.h * jit-recording.cc * jit-recording.h * libgccjit.cc * libgccjit.h * libgccjit.map gcc/testsuite/jit.dg: PR jit/TODO * all-non-failing-tests.h * test-target-builtins.c
Fix compilation error when bfloat is unsupported
Add test for cold attribute in libgccjit
fixup! WIP: Add support for function attributes
Add ability to get CPU features
Add support for returns_twice attribute in libgccjit
Add support for multiple integers value for attribute and `NonNull`
GuillaumeGomez
force-pushed
the
fn-inline
branch
from
adda650
to
1ddee47
Compare
GuillaumeGomez
pushed a commit
to GuillaumeGomez/gcc
that referenced
this pull request
Jan 10, 2024
…-int (PR target/112413)
On m68k the compiler assumes that the PC-relative jump-via-jump-table
instruction and the jump table are adjacent with no padding in between.
When -mlong-jump-table-offsets is combined with -malign-int, a 2-byte
nop may be inserted before the jump table, causing the jump to add the
fetched offset to the wrong PC base and thus jump to the wrong address.
Fixed by referencing the jump table via its label. On the test case
in the PR the object code change is (the moveal at 16 is the nop):
a: 6536 bcss 42 <f+0x42>
c: e588 lsll rust-lang#2,%d0
e: 203b 0808 movel %pc@(18 <f+0x18>,%d0:l),%d0
- 12: 4efb 0802 jmp %pc@(16 <f+0x16>,%d0:l)
+ 12: 4efb 0804 jmp %pc@(18 <f+0x18>,%d0:l)
16: 284c moveal %a4,%a4
18: 0000 0020 orib rust-lang#32,%d0
1c: 0000 002c orib rust-lang#44,%d0
Bootstrapped and tested on m68k-linux-gnu, no regressions.
Note: I don't have commit rights to I would need assistance applying this.
PR target/112413
gcc/
* config/m68k/linux.h (ASM_RETURN_CASE_JUMP): For
TARGET_LONG_JUMP_TABLE_OFFSETS, reference the jump table
via its label.
* config/m68k/m68kelf.h (ASM_RETURN_CASE_JUMP): Likewise.
* config/m68k/netbsd-elf.h (ASM_RETURN_CASE_JUMP): Likewise.
antoyo
force-pushed
the
master
branch
8 times, most recently
from
a2d83f6
to
3988ccc
Compare
antoyo
force-pushed
the
master
branch
2 times, most recently
from
51fa28a
to
be000af
Compare
antoyo
force-pushed
the
master
branch
2 times, most recently
from
cdd8978
to
ad4ffde
Compare
antoyo
force-pushed
the
master
branch
3 times, most recently
from
9cec8ab
to
c4ee893
Compare
antoyo
force-pushed
the
master
branch
6 times, most recently
from
1e817bd
to
b4002fd
Compare
antoyo
force-pushed
the
master
branch
4 times, most recently
from
2e49eb4
to
85e56c5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.