[Clippy] Fix clippy issues in libgit2-sys crate - #1299
Merged
weihanglo merged 3 commits intoJul 20, 2026
Conversation
…t2-sys/build.rs Simplfy the build script's `main()` function to remove the needless borrow.
Simplfy the build script's `main()` function to use `Option::is_some_and()` rather than `Option::map_or()`.
…b.rs Replace `usize::max_value()` with the constant `usize::MAX` in the definition of `GIT_REBASE_NO_OPERATION`.
DanielEScherzer
force-pushed
the
clippy-fixes-libgit2-sys
branch
from
July 19, 2026 20:02
df1d114 to
786d2d9
Compare
weihanglo
approved these changes
Jul 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Commits are split by file and lint for ease of review.
None of the issues required keeping the old code with an
#[expect]attribute, they could all be fixed.